Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): remove SingletonMuxer #3883

Merged
merged 3 commits into from
May 8, 2023
Merged

feat(core): remove SingletonMuxer #3883

merged 3 commits into from
May 8, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

This is effectively dead code as nothing within rust-libp2p uses it. Users should provide it themselves if they need it.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

thomaseizinger
thomaseizinger commented May 5, 2023
View reviewed changes
core/CHANGELOG.md Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger added this to the v0.52.0 milestone May 5, 2023
mxinden
mxinden approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

@mxinden mxinden added the send-it label May 8, 2023
@mergify mergify bot merged commit 15c623c into master May 8, 2023
@mergify mergify bot deleted the remove-singleton-muxer branch May 8, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
v0.52.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @mxinden